Skip to content

fix(storybook): filter non-component icon exports #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Aug 9, 2026
Merged

fix(storybook): filter non-component icon exports #2544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/ui/stories/icons.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,20 @@ interface IconEntry {
Comp: ElementType<{ size?: number | string; strokeWidth?: number | string; 'aria-hidden'?: boolean }>;
}

// The icon seam also exports shared metadata such as ICON_SIZE. Keep the story
// self-updating without assuming every runtime export can be rendered.
function isIconComponent(value: unknown): value is IconEntry['Comp'] {
return (
typeof value === 'function' ||
(typeof value === 'object' &&
value !== null &&
'render' in value &&
typeof value.render === 'function')
);
}

const LUCIDE_ICONS: IconEntry[] = Object.entries(Icons)
.map(([name, value]) => ({ name, Comp: value as IconEntry['Comp'] }))
.flatMap(([name, value]) => (isIconComponent(value) ? [{ name, Comp: value }] : []))
.sort((a, b) => a.name.localeCompare(b.name));

// Derived from BOT_BRAND, the registry BotBrandLogo itself reads. A hand-kept
Expand Down
Loading