test: delete obsolete presentation and helper suites - #2478
Merged
Merged
Conversation
Astro-Han
marked this pull request as ready for review
August 8, 2026 05:32
This was referenced Aug 8, 2026
4 tasks
ggbdpq
added a commit
to ggbdpq/maka
that referenced
this pull request
Sep 11, 2026
Four follow-ups from the review of the A10 audit: - foundation-contract layer 3 now says what apache#4803 actually did: the broad route inventory was retired rather than relocated, nothing enumerates routes against a running Electron app, and layer 2's ax-tree-audit.mjs runs Storybook-only. The old text claimed equivalent coverage that apache#4803 explicitly declined to make, and the adjacent "Storybook 与 Electron E2E 共用" line said the same thing. - ui-coverage: the three prose passages still describing the retired Electron spec (dynamic settings-navigation enumeration, named-dialog overlay sequencing, running-UI inventory) are corrected the same way, so the two documents no longer contradict each other. - translation_status is source-only on all nine documents: none has a counterpart, and main's convention reserves synced for pairs. - provenance §3 marks the binary-recovered cursor facts as removed by apache#3293 (hotspot is now the glyph tip); codex-pip notes that the pip-motion test it cited as exact coverage was deleted by apache#2478; provider-evidence says four evidence classes; the lease-class list matches computer-use.ts's four classes; the window-action lesson is annotated with its date. Refs apache#3522 Generated-by: GLM-5.3-Flash (ZCode)
ggbdpq
added a commit
to ggbdpq/maka
that referenced
this pull request
Sep 11, 2026
Four follow-ups from the review of the A10 audit: - foundation-contract layer 3 now says what apache#4803 actually did: the broad route inventory was retired rather than relocated, nothing enumerates routes against a running Electron app, and layer 2's ax-tree-audit.mjs runs Storybook-only. The old text claimed equivalent coverage that apache#4803 explicitly declined to make, and the adjacent "Storybook 与 Electron E2E 共用" line said the same thing. - ui-coverage: the three prose passages still describing the retired Electron spec (dynamic settings-navigation enumeration, named-dialog overlay sequencing, running-UI inventory) are corrected the same way, so the two documents no longer contradict each other. - translation_status is source-only on all nine documents: none has a counterpart, and main's convention reserves synced for pairs. - provenance §3 marks the binary-recovered cursor facts as removed by apache#3293 (hotspot is now the glyph tip); codex-pip notes that the pip-motion test it cited as exact coverage was deleted by apache#2478; provider-evidence says four evidence classes; the lease-class list matches computer-use.ts's four classes; the window-action lesson is annotated with its date. Refs apache#3522 Generated-by: GLM-5.3-Flash (ZCode)
ggbdpq
added a commit
to ggbdpq/maka
that referenced
this pull request
Sep 12, 2026
Review follow-up on apache#5172. The audit paragraph attributed the PiP window's motion constants to the apache#3293 cursor replacement, but `pip-motion.ts` is byte-identical before apache#3456, after it, and at this head — the replacement rebuilt the agent cursor engine and glyphs, not the PiP springs or anchor scoring. The paragraph now says the apache#2478 deletion only ends the retired test's coverage, records that the motion module is untouched, and scopes the cursor-provenance link to the agent cursor explicitly. Generated-by: GLM-5.3-Flash (ZCode)
me2seeks
pushed a commit
that referenced
this pull request
Sep 12, 2026
* docs: audit the Computer Use documentation group (#3522) Audit the nine Computer Use documents against current source: - foundation-contract: the layer-3 verification description still named apps/desktop/e2e/accessibility-coverage.spec.ts, which #4803 retired with the broad route inventories; the section now records that the coverage is carried by the ax-tree-audit rules and the Storybook smoke at their owning boundaries. - The other eight documents verified clean: command names and lab fixture variables (evidence-classes), outcome types and the deterministic harness (host-events-contract), the maka_computer action surface and fail-closed coordinate policy (model-loop), provenance paths and bundled-tools pinning (provenance, cursor-provenance), report classes and sanitizer scripts (provider-evidence), and the story manifest (ui-coverage). - All nine gain the standard frontmatter with last_verified dates. Refs #3522 Generated-by: GLM-5.3-Flash (ZCode) * docs: correct the Computer Use audit per review Four follow-ups from the review of the A10 audit: - foundation-contract layer 3 now says what #4803 actually did: the broad route inventory was retired rather than relocated, nothing enumerates routes against a running Electron app, and layer 2's ax-tree-audit.mjs runs Storybook-only. The old text claimed equivalent coverage that #4803 explicitly declined to make, and the adjacent "Storybook 与 Electron E2E 共用" line said the same thing. - ui-coverage: the three prose passages still describing the retired Electron spec (dynamic settings-navigation enumeration, named-dialog overlay sequencing, running-UI inventory) are corrected the same way, so the two documents no longer contradict each other. - translation_status is source-only on all nine documents: none has a counterpart, and main's convention reserves synced for pairs. - provenance §3 marks the binary-recovered cursor facts as removed by #3293 (hotspot is now the glyph tip); codex-pip notes that the pip-motion test it cited as exact coverage was deleted by #2478; provider-evidence says four evidence classes; the lease-class list matches computer-use.ts's four classes; the window-action lesson is annotated with its date. Refs #3522 Generated-by: GLM-5.3-Flash (ZCode) * docs: separate PiP motion provenance from the cursor replacement Review follow-up on #5172. The audit paragraph attributed the PiP window's motion constants to the #3293 cursor replacement, but `pip-motion.ts` is byte-identical before #3456, after it, and at this head — the replacement rebuilt the agent cursor engine and glyphs, not the PiP springs or anchor scoring. The paragraph now says the #2478 deletion only ends the retired test's coverage, records that the motion module is untouched, and scopes the cursor-provenance link to the agent cursor explicitly. Generated-by: GLM-5.3-Flash (ZCode)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue the aggressive cleanup from #2462 by deleting obsolete tests, orphaned prompt fixtures, and dead test-only APIs across Desktop, Core, Headless, UI, CLI, Computer Use, Runtime, and Runtime Host.
The branch changes 110 files with 13 additions and 8,343 deletions (net -8,330). Removed coverage is dominated by:
Focused validation found one runtime-loaded Harbor config that the static scan had misclassified as orphaned. That active asset was restored; only its source-string mirror test remains deleted.
Knip exposed and this PR also removes:
_detectColorLevelForTestingisTaskRunLocatorWhy this is safe
Unique coverage alone was not treated as a retention reason. The retained suite still protects the active product contracts whose failure cost matches test maintenance: authorization, secrets, persistence, recovery, fail-closed protocols, dependency patches, and external-process lifecycle.
Explicitly retained guards
patches/README.md: AI SDK tool-call tracking, Astryx List accessible naming, grouped diff counts, new-message reset behavior, and blank UA-CH platform fallbackVerification
git diff --check origin/main...HEAD— passednpm run format:check/npm run format— passednpm run lint— passednpx knipcompared with the clean root checkout — no new findings; four existing unused Headless exports are goneCI
All triggered checks passed on the expanded third-pass diff:
typechecktest_workspacestest_headlesstest_runtime_hoste2e_shard (1/2)ande2e_shard (2/2)testande2egatesalignment_auditwindows_baseline (non-blocking)storybookwas correctly skipped because this PR does not change stories.Review focus
Residual risk is intentionally concentrated in presentation regressions, exact helper formatting, provider-list drift, and small cross-platform/toolchain display behavior. Active dependency configs and all explicit security, authority, persistence, recovery, protocol, sandbox, and process-lifecycle guards remain.