Skip to content

test: trim low-value tests across headless and desktop #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackwener merged 1 commit into from
Aug 7, 2026
Merged

test: trim low-value tests across headless and desktop #2406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
600 changes: 0 additions & 600 deletions apps/desktop/src/main/__tests__/css-test-helpers.test.ts
View file
Open in desktop

This file was deleted.

47 changes: 1 addition & 46 deletions packages/headless/src/__tests__/ab-run.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,52 +263,7 @@ describe('runAbComparison', () => {
assert.equal(result.stopReason, 'observed_cost_stop_reached');
});

test('closes pair admission as soon as one arm reaches the observed cost threshold', async () => {
const calls: string[] = [];
let releaseSibling!: () => void;
const siblingMayFinish = new Promise<void>((resolve) => {
releaseSibling = resolve;
});
let secondPairFinished!: () => void;
const secondPairFinishedPromise = new Promise<void>((resolve) => {
secondPairFinished = resolve;
});
let secondPairArms = 0;
const comparison = runAbComparison({
runId: 'ab-run',
arms: [
{ id: 'off', kind: 'runtime', fingerprint: sha256('off') },
{ id: 'on', kind: 'runtime', fingerprint: sha256('on') },
],
evaluationTasks: [
{ id: 't1', path: '/tasks/t1' },
{ id: 't2', path: '/tasks/t2' },
{ id: 't3', path: '/tasks/t3' },
],
reps: 1,
maxConcurrency: 2,
observedCostStopUsd: 0.01,
runArm: async ({ arm, task }) => {
calls.push(`${task.id}:${arm.id}`);
if (task.id === 't1' && arm.id === 'on') await siblingMayFinish;
if (task.id === 't2') {
secondPairArms += 1;
if (secondPairArms === 2) secondPairFinished();
}
return completed(task.id, true);
},
});

await secondPairFinishedPromise;
await new Promise<void>((resolve) => setImmediate(resolve));
const suffixStartedBeforeDrain = calls.some((call) => call.startsWith('t3:'));
releaseSibling();
const result = await comparison;

assert.equal(suffixStartedBeforeDrain, false);
assert.deepEqual(new Set(calls), new Set(['t1:off', 't1:on', 't2:off', 't2:on']));
assert.equal(result.stopReason, 'observed_cost_stop_reached');
});
;

test('stops scheduling new pairs after a systemic provider failure', async () => {
const calls: string[] = [];
Expand Down
Loading
Loading