Skip to content

Fail closed on invalid telemetry files - #168

Merged
jackwener merged 1 commit into
mainfrom
xuan/fail-closed-telemetry-schema
Jun 23, 2026
Merged

jackwener merged 1 commit into
mainfrom
xuan/fail-closed-telemetry-schema

Conversation

@jackwener

Copy link
Copy Markdown
Member

Summary

  • reject telemetry.json when the top-level value is not a telemetry object
  • reject unknown-section objects and known telemetry sections with non-array values
  • keep partial legacy files with known array sections readable
  • add regressions that verify invalid bytes are not overwritten

Verification

  • npm --workspace @maka/storage test
  • npm run build
  • git diff --check

@jackwener
jackwener merged commit 60fe629 into main Jun 23, 2026
@jackwener
jackwener deleted the xuan/fail-closed-telemetry-schema branch June 23, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant