Skip to content

Validate PatternParser DTDs against expected name#1358

Merged
paulirwin merged 2 commits into
apache:masterfrom
paulirwin:bugfix/patternparser-dtd
Jun 16, 2026
Merged

Validate PatternParser DTDs against expected name#1358
paulirwin merged 2 commits into
apache:masterfrom
paulirwin:bugfix/patternparser-dtd

Conversation

@paulirwin

Copy link
Copy Markdown
Contributor
  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Validate PatternParser DTDs against expected name

Description

The PatternParser DtdResolver does not validate that the file name is the expected one, falling back to the default behavior. This resolves that by throwing instead if it does not match. Unit test coverage added to match.

@paulirwin paulirwin requested a review from NightOwl888 June 16, 2026 20:22
@paulirwin paulirwin added the notes:bug-fix Contains a fix for a bug label Jun 16, 2026
@paulirwin paulirwin merged commit a6f4657 into apache:master Jun 16, 2026
209 checks passed
@paulirwin paulirwin deleted the bugfix/patternparser-dtd branch June 16, 2026 20:41
paulirwin added a commit to paulirwin/lucene.net that referenced this pull request Jun 16, 2026
This was referenced Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:bug-fix Contains a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants