Replace lucene.testSettings.config references with lucene.testsettings.json#1035
Merged
Conversation
paulirwin
added
the
notes:website-or-documentation
NightOwl888
added a commit
that referenced
this pull request
May 29, 2025
…ress concurrency problems (Fixes #1035, #1135, and #1159) (#1161) * Lucene.Net.Analysis.Th.ThaiTokenizer + Lucene.Net.Analysis.Icu.Segmentation.ICUTokenizer: Removed static locks that were used to prevent concurent access to BreakIterator. The concurrency issue with BreakIterator has been addressed in ICU4N 60.1.0-alpha.437. Fixes #1044. Fixes #1135. * .build/dependencies.props: Bumped ICU4N to 60.1.0-alpha.438.g06cf803beb * azure-pipelines.yml: Bumped SDK version to 9.0.300 so we copy all of the ICU4N satellite assemblies to the build output. * .build/runbuild.ps1: Bumped minimum SDK version to 9.0.200 so ICU4N satellite assemblies are copied to the build output. * BUG: Lucene.Net.Analysis.Th.ThaiWordBreaker::SetText(): Clear the transitions array when resetting the text, since there may be state from a previous use. * Lucene.Net.Analysis.BaseTokenStreamTestCase::CheckAnalysisConsistency(): AssertTokenStreamContents already consumes the token stream and calls Close(), so removed duplicate Close() call in finally block. See #1159. * Lucene.Net.Analysis.BaseTokenStreamTestCase::AssertTokenStreamContents(): reset the token stream upon error so Close() doesn't throw an invalid state exception that would obscure our real test error message. * Lucene.Net.Analysis.BaseTokenStreamTestCase (AssertTokenStreamComponents() + CheckAnalysisConsistency()): When using MockTokenizer, disable the state checks upon exception so our call to Close() won't throw another exception that may obscure the original test failure. * Lucene.Net.Analysis.Th.TestThaiAnalyzer::AssertAnalyzer(): When using MockTokenizer, disable the state checks upon exception so our call to Close() won't throw another exception that may obscure the original test failure. * Lucene.Net.Analysis (BaseTokenStreamTestCase + Th.TestThaiAnalyzer): Log any secondary exceptions from TokenStream.Close(), since we don't want them to obscure our original test failure message. Throw only in the case where there was no other failure and Close() throws. * .build/dependencies.props: bumped ICU4N to 60.1.0-alpha.438 * Lucene.Net.Analysis.Th.ThaiTokenizer: Removed extra helper methods/overloads that only existed to synchronize access to the BreakIterator instances
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Oct 31, 2025
paulirwin
added a commit
to paulirwin/lucene.net
that referenced
this pull request
Jun 16, 2026
This was referenced Jun 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace lucene.testSettings.config references with lucene.testsettings.json
Fixes #997
Description
There were still some places in comments where we were referencing
lucene.testSettings.configas the file name for setting your seed/culture, when it should belucene.testsettings.json. This does a solution-wide find and replace for those occurrences in comments.