LUCENE-10242: The TopScoreDocCollector::createSharedManager should use ScoreDoc instead of FieldDoc

[reta]

Signed-off-by: Andriy Redko [email protected]

Description

The TopScoreDocCollector::createSharedManager should use ScoreDoc instead of FieldDoc as a type of after argument. The FieldDoc is really needed only in case of TopFieldCollector but now its usage is mandated by TopScoreDocCollector and leads to unnecessary conversion tricks.

Solution

Relax after argument type from FieldDoc to ScoreDoc

Tests

The functionality is covered by existing tests. Since FieldDoc is a subclass of ScoreDoc, the change is fully compatible and non breaking.

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.

[reta]

Thank you @jpountz !