Refactor computeCommonPrefixLengthAndBuildHistogram#15016
Closed
HUSTERGS wants to merge 1 commit intoapache:mainfrom
Closed
Refactor computeCommonPrefixLengthAndBuildHistogram#15016HUSTERGS wants to merge 1 commit intoapache:mainfrom
HUSTERGS wants to merge 1 commit intoapache:mainfrom
Conversation
…ash (apache#12905)" This reverts commit a6f70ad.
Contributor
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
Contributor
Author
|
Since the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since jdk24 is required (#14533) maybe it's safe to revert #12905, which was introduced to work around a JDK bug.
This pr essentially reverts #12905 (but kept the added crash test), so the related code under
MSBRadixSorterandRadixSelectorcan be more clear