Skip to content

build: check vectors code with error-prone #14917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uschindler merged 2 commits into from
Jul 23, 2025
Merged

build: check vectors code with error-prone #14917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c3ae2d
build: check vectors code with error-prone
rmuir Jul 8, 2025
094fe3c
Merge branch 'apache:main' into vectors_are_definitely_error_prone
uschindler Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions build-tools/build-infra/src/main/groovy/lucene.validation.error-prone.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ allprojects { prj ->
}

tasks.withType(JavaCompile).configureEach { task ->
// Disable errorprone on the MR-JAR tasks
Copy link
Contributor

@uschindler uschindler Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this was added when the MR-JAR code required newer JDK to be installed in former times. This is now obsolete as we have APIJARs and on top at moment we compile with default compiler (24).

if (task.name ==~ /compileMain\d+Java/) {
options.errorprone.enabled = false
return
}

// Exclude certain files (generated ones, mostly).
switch (project.path) {
case ":lucene:core":
Expand Down
1 change: 1 addition & 0 deletions ...src/java24/org/apache/lucene/internal/vectorization/MemorySegmentPostingDecodingUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ private static void shift(
}

@Override
@SuppressWarnings("NarrowCalculation") // count * 4 won't overflow integer here
public void splitInts(
int count, int[] b, int bShift, int dec, int bMask, int[] c, int cIndex, int cMask)
throws IOException {
Expand Down
Loading