Fix IndexSortSortedNumericDocValuesRangeQuery for int sort#14732
Merged
mayya-sharipova merged 2 commits intoapache:mainfrom May 30, 2025
Merged
Conversation
This query assumend that missing value is always of type long. This modifies it to allow type int as well. The test is added that fails without this change.
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
Contributor
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. |
mayya-sharipova
commented
May 29, 2025
| } | ||
| } | ||
|
|
||
| public void testSameHitsAsPointRangeQueryIntSort() throws IOException { |
Contributor
Author
There was a problem hiding this comment.
Copy of the previous testSameHitsAsPointRangeQuery() but on Integer sort.
gf2121
approved these changes
May 30, 2025
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 30, 2025
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
mayya-sharipova
added a commit
that referenced
this pull request
May 30, 2025
This query assumed that missing value is always of type long. This modifies it to allow type int as well. The test is added that fails without this change.
mayya-sharipova
added a commit
to mayya-sharipova/lucene
that referenced
this pull request
May 30, 2025
) This query assumed that missing value is always of type long. This modifies it to allow type int as well. The test is added that fails without this change. Backport for apache#14732
mayya-sharipova
added a commit
that referenced
this pull request
May 30, 2025
benwtrent
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 2, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jun 2, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot (cherry picked from commit 2a44166)
mridula-s109
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 2, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
elasticsearchmachine
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 2, 2025
…8764) * Applying Apache Lucene fix: apache/lucene#14732 (#128671) * Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot (cherry picked from commit 2a44166) * [CI] Auto commit changes from spotless * adding forbidden api check --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Jun 2, 2025
) * Applying Apache Lucene fix: apache/lucene#14732 (#128671) * Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot (cherry picked from commit 2a44166) * adding forbidden APIs check
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
* Applying Apache Lucene fix: apache/lucene#14732 * fixing test * fixing annot
mayya-sharipova
added a commit
that referenced
this pull request
Jun 12, 2025
This query assumed that missing value is always of type long. This modifies it to allow type int as well. The test is added that fails without this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This query assumed that missing value is always of type long.
This modifies it to allow type int as well.
The test is added that fails without this change.