An improved check for ignoring the c2-crash test if running on a client compiler.#12953
Merged
dweiss merged 3 commits intoapache:mainfrom Dec 18, 2023
Merged
An improved check for ignoring the c2-crash test if running on a client compiler.#12953dweiss merged 3 commits intoapache:mainfrom
dweiss merged 3 commits intoapache:mainfrom
Conversation
Contributor
|
FYI, there's also |
uschindler
requested changes
Dec 18, 2023
Contributor
uschindler
left a comment
uschindler
left a comment
There was a problem hiding this comment.
Remove this method, too (it is dead code):
Contributor
|
This is why it works and you can still run the tests with This PR just detects directly if Client VM is used. So it doesn't matter if it is caused by CI enabled or if you run it in your IDE with some custom config. |
Contributor
Author
|
I've removed the unused method and added hotspot check, thanks Uwe. |
uschindler
approved these changes
Dec 18, 2023
dweiss
changed the title
asfgit
pushed a commit
that referenced
this pull request
Dec 18, 2023
Contributor
Author
|
I've applied this to main and branch_9x. |
Contributor
|
I'm way too slow here, sorry. Belated LGTM. And thanks for following up on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12905