Repository navigation
one home for the reflection in the tests - #326
Merged
Merged
Conversation
ReflectionExtensions replaces 27 hand written lookups in 13 files. A renamed member now fails with its own name instead of a NullReferenceException.
FreeAndNil
force-pushed
the
Feature/326-test-reflection
branch
from
September 25, 2026 05:59
d9d4cc1 to
34fca46
Compare
FreeAndNil
marked this pull request as ready for review
September 25, 2026 05:59
fluffynuts
approved these changes
Sep 25, 2026
gdziadkiewicz
approved these changes
Sep 25, 2026
FreeAndNil
added a commit
that referenced
this pull request
Sep 28, 2026
…stead of dropping the client Every throw from a Telnet write was read as a dead client, so a bug in what we write dropped every client, one per event. That was f013. Only `SocketException`, `IOException` and `ObjectDisposedException` disconnect now. The rest is rethrown after the loop and reported by `BackgroundSender`. Commit 2, test-only: * `AdoNetAppenderTest` twice, `XmlConfiguratorTest`, `LogLogTest`, `StringFormatTest` once each * ten provoked `log4net:ERROR` off stderr, two left, asserted by `LogLogTest` * `CLAUDE.md` gets the `ReflectionExtensions` convention from #326
This was referenced Oct 1, 2026
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One
ReflectionExtensionsin the test assembly replaces 27 hand written lookups over 13 files.Test only, no production change, no changelog entry.
A renamed member now fails with its own name instead of a
NullReferenceException.