Repository navigation
stop appenders losing or leaking what they write - #324
Merged
Merged
Conversation
FreeAndNil
added a commit
that referenced
this pull request
Sep 21, 2026
- a parameter named like a secret is logged as *****, connection strings keep only the keywords that name the server - covers internal debugging and the four setter failures, which are written without it - the AdoNet connection string redaction moves to log4net.Util.Redact and is now shared
FreeAndNil
added a commit
that referenced
this pull request
Sep 21, 2026
- the file is an RFC 822 message, not an SMTP DATA stream, so the terminator bought nothing - a logged line that was only a dot was indistinguishable from it and ended the mail early for any agent honouring it audit da18b6f-f037
FreeAndNil
force-pushed
the
Feature/324-sinks-and-debug-echo
branch
from
September 21, 2026 19:50
b3c4377 to
094e872
Compare
- the socket rejects a payload over 65507 bytes, so the event was lost - new MaxDatagramSize, default 65507, configurable from 512 - cut on a character boundary, marked with ...[truncated] - RemoteSyslogAppender uses the same encoder audit da18b6f-f015
- a parameter named like a secret is logged as *****, connection strings keep only the keywords that name the server - covers internal debugging and the four setter failures, which are written without it - the AdoNet connection string redaction moves to log4net.Util.Redact and is now shared
- the file is an RFC 822 message, not an SMTP DATA stream, so the terminator bought nothing - a logged line that was only a dot was indistinguishable from it and ended the mail early for any agent honouring it audit da18b6f-f037
FreeAndNil
force-pushed
the
Feature/324-sinks-and-debug-echo
branch
from
September 23, 2026 18:20
094e872 to
5049c46
Compare
FreeAndNil
marked this pull request as ready for review
September 23, 2026 18:20
fluffynuts
approved these changes
Sep 24, 2026
This was referenced Oct 1, 2026
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
MaxDatagramSize, default 65507, configurable from 512...[truncated]and reported*****AdoNetAppender's allowlist moved tolog4net.Util.Redactand is now shared