Skip to content

stop appenders losing or leaking what they write - #324

Merged
FreeAndNil merged 3 commits into
masterfrom
Feature/324-sinks-and-debug-echo
Sep 24, 2026
Merged

FreeAndNil merged 3 commits into
masterfrom
Feature/324-sinks-and-debug-echo

Conversation

@FreeAndNil

@FreeAndNil FreeAndNil commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixed

  • An oversize event was dropped by the UDP appenders, audit da18b6f-f015
    • the socket rejects a payload over 65507 bytes, measured here: 65507 is sent, 65508 fails
    • new MaxDatagramSize, default 65507, configurable from 512
    • the event is cut on a character boundary, marked ...[truncated] and reported
    • not raisable: IPv6 would carry 20 bytes more, not worth a second limit
  • The configurator echoed secret values, audit da18b6f-f042
    • a parameter named like a secret is now logged as *****
    • a connection string keeps only the keywords that name the server
    • covers internal debugging and the four setter failures, which are written without it
    • AdoNetAppender's allowlist moved to log4net.Util.Redact and is now shared
  • The pickup mail carried an SMTP DATA terminator, audit da18b6f-f037
    • the file is read to its end, so the lone dot was delivered as a literal line
    • it is gone; body lines stay verbatim and are not dot stuffed
    • an agent that expects DATA framing is documented as not a supported consumer

@FreeAndNil FreeAndNil added this to the 3.5.0 milestone Sep 21, 2026
FreeAndNil added a commit that referenced this pull request Sep 21, 2026
- a parameter named like a secret is logged as *****, connection strings keep only the keywords that name the server
- covers internal debugging and the four setter failures, which are written without it
- the AdoNet connection string redaction moves to log4net.Util.Redact and is now shared
FreeAndNil added a commit that referenced this pull request Sep 21, 2026
- the file is an RFC 822 message, not an SMTP DATA stream, so the terminator
  bought nothing
- a logged line that was only a dot was indistinguishable from it and ended the
  mail early for any agent honouring it

audit da18b6f-f037
@FreeAndNil FreeAndNil changed the title truncate an oversize UDP datagram instead of losing the event stop the sinks losing or leaking what they write Sep 21, 2026
@FreeAndNil
FreeAndNil force-pushed the Feature/324-sinks-and-debug-echo branch from b3c4377 to 094e872 Compare September 21, 2026 19:50
- the socket rejects a payload over 65507 bytes, so the event was lost
- new MaxDatagramSize, default 65507, configurable from 512
- cut on a character boundary, marked with ...[truncated]
- RemoteSyslogAppender uses the same encoder

audit da18b6f-f015
- a parameter named like a secret is logged as *****, connection strings keep only the keywords that name the server
- covers internal debugging and the four setter failures, which are written without it
- the AdoNet connection string redaction moves to log4net.Util.Redact and is now shared
- the file is an RFC 822 message, not an SMTP DATA stream, so the terminator
  bought nothing
- a logged line that was only a dot was indistinguishable from it and ended the
  mail early for any agent honouring it

audit da18b6f-f037
@FreeAndNil
FreeAndNil force-pushed the Feature/324-sinks-and-debug-echo branch from 094e872 to 5049c46 Compare September 23, 2026 18:20
@FreeAndNil FreeAndNil changed the title stop the sinks losing or leaking what they write stop appenders losing or leaking what they write Sep 23, 2026
@FreeAndNil
FreeAndNil marked this pull request as ready for review September 23, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants