#250 mocked DateTimeStrategy to speedup test #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FreeAndNil
commented
Jul 2, 2025
FreeAndNil
commented
- added release notes
- added license headers
- adjusted Log4NetIntegrationTests to .editorconfig
- added release notes - added license headers - adjusted Log4NetIntegrationTests to .editorconfig
|
@gdziadkiewicz I've cleaned up a little bit. Can you take a look? |
|
Yes |
fluffynuts
reviewed
Jul 3, 2025
| baseFile = baseFile.ToLowerInvariant(); | ||
| string dir = string.IsNullOrEmpty(baseFile) ? "" : Path.GetDirectoryName(baseFile); | ||
| var baseFileWithoutExtension = Path.Combine(dir ?? "", Path.GetFileNameWithoutExtension(baseFile)); | ||
| string baseFileWithoutExtension = Path.Combine(dir ?? "", Path.GetFileNameWithoutExtension(baseFile)); |
There was a problem hiding this comment.
is there a new style choice to prefer types over var? just curious - I see that you prefer, eg,
SomeType thing = new();over
var thing = new SomeType();elsewhere - so perhaps this is just a habit 😄 not a big deal - just curious
There was a problem hiding this comment.
Yes, I prefer SomeType thing = new(); because you can use the same Pattern for Lists: List<string> list = [];
var list = new List<string>(); is "much" longer ;-)
Even the version for simple objects is now shorter without var. I only use var for complex Linq-Queries or when I don't know what to expect 😄
fluffynuts
approved these changes
Jul 3, 2025
FreeAndNil
deleted the
Feature/262-mocked-DateTimeStrategy-to-speedup-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.