#246 fix InvalidCastException in ThreadContextStack.InternalStack.set #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeAndNil
changed the title
FreeAndNil
force-pushed
the
Feature/#244-fix-InvalidCastException-in-ThreadContextStack.InternalStack.set
branch
from
25b27ed to
a65c1d5
Compare
fluffynuts
approved these changes
May 22, 2025
| for (int i = frames.Length - 1; i >= 0; i--) | ||
| { | ||
| _stack.Push(frames[i]); | ||
| _stack.Push(frames[i].EnsureIs<StackFrame>()); |
There was a problem hiding this comment.
minor: I'd suggest rather using pettern-matching instead of throwing if something in that array is wrong, eg
if (frames[i] is StackFrame s)
{
_stack.Push(s)
}This would stop a throw on invalid data set, but leave the collection empty, which may not be better - this may just be a stylistic choice on my part.
FreeAndNil
deleted the
Feature/#244-fix-InvalidCastException-in-ThreadContextStack.InternalStack.set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #244