Skip to content

Turn on the CI build for PRs #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Turn on the CI build for PRs #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4826105
Divide steps
gdziadkiewicz Nov 1, 2024
9e403e8
Try the approach from build doc
gdziadkiewicz Nov 1, 2024
f924430
Add PR trigger
gdziadkiewicz Nov 2, 2024
f89915a
Fix branch name
gdziadkiewicz Nov 4, 2024
74f8080
Try dotnet build & test
gdziadkiewicz Nov 4, 2024
3afa1c1
Enable quackers
gdziadkiewicz Nov 11, 2024
d2e91d4
Remove Zarro from the CI build
gdziadkiewicz Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ name: build

on:
workflow_dispatch:
push:
branches:
- master
pull_request:

jobs:

Expand All @@ -31,6 +35,10 @@ jobs:
matrix:
os: [ macos-latest, ubuntu-latest, windows-latest ]

env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1

steps:

- name: Checkout repository
Expand All @@ -42,16 +50,10 @@ jobs:
dotnet-version: 8
dotnet-quality: ga

- name: Set up NodeJs
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # 4.0.3
with:
node-version: 20

- name: Build and test
env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLIE_TELEMETRY_OPTOUT: 1
- name: Build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: build step is not required - npm test will build as a pre-requisite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, but it's easier to tell what failed when the phases are separated.

run: |
dotnet build ./src/log4net.sln

- name: Test
run: |
npm update -g npm --no-progress
npm install --no-progress
npm test
dotnet test ./src/log4net.sln
1 change: 1 addition & 0 deletions src/log4net.Tests/log4net.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<DefineConstants>TRACE;DEBUG;$(DefineConstants)</DefineConstants>
<!-- suppress analyzer mismatch warning -->
<NoWarn>CS8032</NoWarn>
<VSTestLogger>quackers</VSTestLogger>
</PropertyGroup>
<ItemGroup>
<Compile Include="..\log4net\Diagnostics\CodeAnalysis\CallerArgumentExpressionAttribute.cs" Link="Diagnostics\CodeAnalysis\CallerArgumentExpressionAttribute.cs" />
Expand Down