[KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name #7039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7039 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 695 695
Lines 42816 42827 +11
Branches 5830 5832 +2
======================================
- Misses 42816 42827 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Member
Author
|
turboFei
force-pushed
the
fix_test
branch
3 times, most recently
from
3274eb7 to
a5d22af
Compare
turboFei
changed the title
turboFei
force-pushed
the
fix_test
branch
2 times, most recently
from
5f383b0 to
c4100b0
Compare
turboFei
changed the title
turboFei
force-pushed
the
fix_test
branch
2 times, most recently
from
4ff56cc to
b7914d4
Compare
pan3793
reviewed
Apr 25, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ApplicationOperation.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Apr 25, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala
Outdated
Show resolved
Hide resolved
Member
|
LGTM, only a nit about style |
Member
Author
|
The spark k8s IT has passed, merging to fix the GA. |
turboFei
added a commit
that referenced
this pull request
Apr 25, 2025
### Why are the changes needed? Followup for #7034 to fix the SparkOnKubernetesTestsSuite. Sorry, I forget that the appInfo name and pod name were deeply bound before, the appInfo name was used as pod name and used to delete pod. In this PR, we add `podName` into applicationInfo to separate app name and pod name. ### How was this patch tested? GA should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7039 from turboFei/fix_test. Closes #7034 0ff7018 [Wang, Fei] revert 18e48c0 [Wang, Fei] comments 19f34bc [Wang, Fei] do not get pod name from appName c1d3084 [Wang, Fei] reduce interval for test stability 50fad6b [Wang, Fei] fix ut Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit 75891d1) Signed-off-by: Wang, Fei <fwang12@ebay.com>
Member
Author
|
thanks, merged to main and 1.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Followup for #7034 to fix the SparkOnKubernetesTestsSuite.
Sorry, I forget that the appInfo name and pod name were deeply bound before, the appInfo name was used as pod name and used to delete pod.
In this PR, we add
podNameinto applicationInfo to separate app name and pod name.How was this patch tested?
GA should pass.
Was this patch authored or co-authored using generative AI tooling?
No.