Using mutable JettyServer uri to prevent batch kyuubi instance mismatch #7017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
This reverts commit b64d91b.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7017 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 694 694
Lines 42753 42760 +7
Branches 5820 5820
======================================
- Misses 42753 42760 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan3793
reviewed
Apr 9, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/server/ui/JettyServer.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Apr 9, 2025
turboFei
added a commit
that referenced
this pull request
Apr 9, 2025
…instance mismatch ### Why are the changes needed? To fix the batch kyuubi instance port is negative issue. <img width="697" alt="image" src="https://github.com/user-attachments/assets/ef992390-8d20-44b3-8640-35496caff85d" /> It happen after I stop the kyuubi service. We should use variable instead of function for jetty server serverUri. After the server connector stopped, the localPort would be `-2`.  ### How was this patch tested? Existing UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7017 from turboFei/server_port_negative. Closes #7017 3d34c40 [Wang, Fei] warn e582986 [Wang, Fei] mutable server uri 2cbaf77 [Wang, Fei] Revert "hard code the server uri" b64d91b [Wang, Fei] hard code the server uri Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit 0cc52d0) Signed-off-by: Wang, Fei <[email protected]>
Member
Author
|
thanks, merging to master and branch-1.10 |
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Aug 27, 2025
…yuubi instance mismatch (apache#688) ### Why are the changes needed? To fix the batch kyuubi instance port is negative issue. <img width="697" alt="image" src="https://github.com/user-attachments/assets/ef992390-8d20-44b3-8640-35496caff85d" /> It happen after I stop the kyuubi service. We should use variable instead of function for jetty server serverUri. After the server connector stopped, the localPort would be `-2`.  ### How was this patch tested? Existing UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#7017 from turboFei/server_port_negative. Closes apache#7017 3d34c40 [Wang, Fei] warn e582986 [Wang, Fei] mutable server uri 2cbaf77 [Wang, Fei] Revert "hard code the server uri" b64d91b [Wang, Fei] hard code the server uri Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To fix the batch kyuubi instance port is negative issue.
It happen after I stop the kyuubi service.
We should use variable instead of function for jetty server serverUri.
After the server connector stopped, the localPort would be
-2.How was this patch tested?
Existing UT.
Was this patch authored or co-authored using generative AI tooling?
No.