Skip to content

Record the session disconnected info into kyuubi session event #7015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
turboFei wants to merge 4 commits into from
Closed

Record the session disconnected info into kyuubi session event #7015

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1cf6f8f
disconnect
turboFei Apr 4, 2025
bca7f9b
post
turboFei Apr 4, 2025
e465214
nit
turboFei Apr 4, 2025
c957092
do not post
turboFei Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTBinaryFrontendService.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@ import java.util.Base64

import org.apache.hadoop.conf.Configuration

import org.apache.kyuubi.KyuubiSQLException
import org.apache.kyuubi.{KyuubiException, KyuubiSQLException}
import org.apache.kyuubi.cli.Handle
import org.apache.kyuubi.config.KyuubiConf
import org.apache.kyuubi.config.KyuubiConf.KYUUBI_SERVER_THRIFT_RESULTSET_DEFAULT_FETCH_SIZE
import org.apache.kyuubi.config.KyuubiReservedKeys._
import org.apache.kyuubi.events.EventBus
import org.apache.kyuubi.ha.client.{KyuubiServiceDiscovery, ServiceDiscovery}
import org.apache.kyuubi.metrics.MetricsConstants._
import org.apache.kyuubi.metrics.MetricsSystem
Expand Down Expand Up @@ -69,6 +70,17 @@ final class KyuubiTBinaryFrontendService(
serverContext: ServerContext,
input: TProtocol,
output: TProtocol): Unit = {
val handle = serverContext.getSessionHandle
if (handle != null) {
be.sessionManager
.getSessionOption(handle)
.map(_.asInstanceOf[KyuubiSessionImpl])
.flatMap(_.getSessionEvent).foreach { sessionEvent =>
sessionEvent.exception = Some(new KyuubiException(
s"Session between client and Kyuubi server disconnected without closing properly."))
EventBus.post(sessionEvent)
Comment thread
turboFei marked this conversation as resolved.
Outdated
}
}
super.deleteContext(serverContext, input, output)
MetricsSystem.tracing { ms =>
ms.decCount(THRIFT_BINARY_CONN_OPEN)
Expand Down