[KYUUBI #6918] Cache client ipAddress in kyuubi jdbc connection #6919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Feb 14, 2025
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Feb 14, 2025
pan3793
reviewed
Feb 14, 2025
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Feb 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6919 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 688 688
Lines 42592 42598 +6
Branches 5806 5807 +1
======================================
- Misses 42592 42598 +6 ☔ View full report in Codecov by Sentry. |
wForget
added a commit
that referenced
this pull request
Feb 14, 2025
### Why are the changes needed? add Utils.CLIENT_IP_ADDRESS to cache local ipAddress closes #6918 ### How was this patch tested? minor fix ### Was this patch authored or co-authored using generative AI tooling? No Closes #6919 from wForget/KYUUBI-6918. Closes #6918 5b0efe7 [Cheng Pan] Update kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/Utils.java b8660c8 [wforget] address comment 835dfb8 [wforget] address comment 29dd13a [wforget] fix style 843b29f [wforget] [KYUUBI #6918] Cache client ipAddress in kyuubi jdbc connection Lead-authored-by: wforget <643348094@qq.com> Co-authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: wforget <643348094@qq.com> (cherry picked from commit 51b8e7b) Signed-off-by: wforget <643348094@qq.com>
Member
Author
|
Thank you, merged to master/1.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
add Utils.CLIENT_IP_ADDRESS to cache local ipAddress
closes #6918
How was this patch tested?
minor fix
Was this patch authored or co-authored using generative AI tooling?
No