[KYUUBI #5484] Remove legacy Web UI #5516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:infra
turboFei
approved these changes
Oct 24, 2023
Contributor
|
LGTM. |
link3280
approved these changes
Oct 25, 2023
cfmcgrady
reviewed
Oct 25, 2023
| server.addStaticHandler("org/apache/kyuubi/ui/static", "/static/") | ||
| server.addRedirectHandler("/", "/static/") | ||
| server.addRedirectHandler("/static", "/static/") | ||
| server.addStaticHandler("META-INF/resources/webjars/swagger-ui/4.9.1/", "/swagger-static/") |
Contributor
There was a problem hiding this comment.
it's safety to remove dep swagger-ui
Lines 836 to 846 in 5cff4fb
Member
Author
There was a problem hiding this comment.
thanks for catching, removed
cfmcgrady
approved these changes
Oct 25, 2023
yaooqinn
pushed a commit
that referenced
this pull request
Oct 25, 2023
### _Why are the changes needed?_ Close #5484 Kyuubi provides a basic new Web UI which is built on top of Vue3, we can remove the legacy dummy Web UI in 1.8. The new UI hosts at `http://<host>:<port>/ui/` and the legacy UI hosts at `http://<host>:<port>/`, we should 1. Remove the legacy UI routing from Jetty 2. Remove all files related to legacy UI 3. Redirect `http://<host>:<port>/` to `http://<host>:<port>/ui/` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate building with the command `build/dist --web-ui`, then `cd dist` and perform `bin/kyuubi run` access http://0.0.0.0:10099 could correctly redirect to http://0.0.0.0:10099/ui/ <img width="1428" alt="image" src="https://github.com/apache/kyuubi/assets/26535726/1e8a67f6-e4db-415e-8a47-dd7c41b487cf"> swagger is render correctly too. <img width="1428" alt="image" src="https://github.com/apache/kyuubi/assets/26535726/1cb4ba31-9965-4468-b7c3-b0319ba959e6"> - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No. Closes #5516 from pan3793/5484. Closes #5484 9d58ef7 [Cheng Pan] address comment and fix test 6d4c098 [Cheng Pan] [KYUUBI #5484] Remove legacy Web UI Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit 75428bb) Signed-off-by: Kent Yao <yao@apache.org>
Member
|
Thank you all, merged to master and 1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #5484
Kyuubi provides a basic new Web UI which is built on top of Vue3, we can remove the legacy dummy Web UI in 1.8.
The new UI hosts at
http://<host>:<port>/ui/and the legacy UI hosts athttp://<host>:<port>/, we shouldhttp://<host>:<port>/tohttp://<host>:<port>/ui/How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
building with the command
build/dist --web-ui, thencd distand performbin/kyuubi runaccess http://0.0.0.0:10099 could correctly redirect to http://0.0.0.0:10099/ui/
swagger is render correctly too.
Was this patch authored or co-authored using generative AI tooling?
No.