Skip to content

[AuthZ] Simplify debug message for missing field/method in ReflectUtils #5497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 5 commits into from
Closed

[AuthZ] Simplify debug message for missing field/method in ReflectUtils #5497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78a66a3
[AuthZ] Simplify debug message for missing field/methond in ReflectUtils
yaooqinn Oct 23, 2023
9f94c62
[AuthZ] Simplify debug message for missing field/methond in ReflectUtils
yaooqinn Oct 23, 2023
b7a7fbb
[AuthZ] Simplify debug message for missing field/methond in ReflectUtils
yaooqinn Oct 23, 2023
23e8e7a
[AuthZ] Simplify debug message for missing field/methond in ReflectUtils
yaooqinn Oct 23, 2023
3ad42d5
addr comments
yaooqinn Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/spark/kyuubi-spark-authz/src/test/resources/log4j2-test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
</File>
</Appenders>
<Loggers>
<Root level="INFO">
<Root level="DEBUG">
Copy link
Member Author

@yaooqinn yaooqinn Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug message in CI for authz module can be turned on as most of its logs are at debug level and now it's less noisy.

<AppenderRef ref="stdout"/>
<AppenderRef ref="file"/>
</Root>
Expand Down
14 changes: 2 additions & 12 deletions kyuubi-util-scala/src/main/scala/org/apache/kyuubi/util/reflect/ReflectUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@ object ReflectUtils {
}
} catch {
case e: Exception =>
val candidates =
(clz.getDeclaredFields ++ clz.getFields).map(_.getName).distinct.sorted
throw new RuntimeException(
s"Field $fieldName not in $clz [${candidates.mkString(",")}]",
e)
throw new RuntimeException(s"$clz does not have $fieldName field", e)
}
}

Expand Down Expand Up @@ -92,14 +88,8 @@ object ReflectUtils {
}
} catch {
case e: Exception =>
val candidates =
(clz.getDeclaredMethods ++ clz.getMethods)
.map(m => s"${m.getName}(${m.getParameterTypes.map(_.getName).mkString(", ")})")
.distinct.sorted
val argClassesNames = argClasses.map(_.getName)
throw new RuntimeException(
s"Method $methodName(${argClassesNames.mkString(", ")})" +
s" not found in $clz [${candidates.mkString(", ")}]",
s"$clz does not have $methodName${argClasses.map(_.getName).mkString("(", ", ", ")")}",
e)
}
}
Expand Down
6 changes: 2 additions & 4 deletions kyuubi-util-scala/src/test/scala/org/apache/kyuubi/util/reflect/ReflectUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,8 @@ class ReflectUtilsSuite extends AnyFunSuite {
"methodNotExists",
(classOf[String], "arg1"),
(classOf[String], "arg2"))
}("Method methodNotExists(java.lang.String, java.lang.String) not found " +
"in class org.apache.kyuubi.util.reflect.ObjectA$ " +
"[equals(java.lang.Object), field5(), field6(), getClass(), hashCode(), method5(), " +
"method6(), notify(), notifyAll(), toString(), wait(), wait(long), wait(long, int)]")
}("class org.apache.kyuubi.util.reflect.ObjectA$ does not have methodNotExists(" +
"java.lang.String, java.lang.String)")
}
}

Expand Down