Skip to content

[KYUUBI #5492][AUTHZ] saveAsTable create DataSource table miss db info #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AngersZhuuuu wants to merge 5 commits into from
Closed

[KYUUBI #5492][AUTHZ] saveAsTable create DataSource table miss db info #5493

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f24728
[KYUUBI #5492] saveAsTable create DataSource table miss db info
AngersZhuuuu Oct 21, 2023
7bcfc23
Merge branch 'master' into KYUUBI-5492
AngersZhuuuu Oct 21, 2023
f56f299
Update RangerSparkExtensionSuite.scala
AngersZhuuuu Oct 21, 2023
7a4c86f
Merge branch 'master' into KYUUBI-5492
AngersZhuuuu Oct 23, 2023
46867af
update
AngersZhuuuu Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,10 @@ class CatalogTableTableExtractor extends TableExtractor {
} else {
val catalogTable = v1.asInstanceOf[CatalogTable]
val identifier = catalogTable.identifier
val db = identifier.database.getOrElse(spark.sessionState.catalog.getCurrentDatabase)
val tableIdentWithDB = identifier.copy(database = Some(db))
val owner = Option(catalogTable.owner).filter(_.nonEmpty)
Some(Table(None, identifier.database, identifier.table, owner))
Some(Table(None, tableIdentWithDB.database, tableIdentWithDB.table, owner))
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions ...rc/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,4 +835,19 @@ class HiveCatalogRangerSparkExtensionSuite extends RangerSparkExtensionSuite {
assert(e2.getMessage.contains(s"does not have [select] privilege on [$db1/$view1/new_id]"))
}
}

test("[KYUUBI #5492] saveAsTable create DataSource table miss db info") {
val table1 = "table1"
withSingleCallEnabled {
withCleanTmpResources(Seq.empty) {
val df = doAs(
admin,
sql(s"SELECT * FROM VALUES(1, 100),(2, 200),(3, 300) AS t(id, scope)")).persist()
val e = intercept[AccessControlException] {
doAs(someone, df.write.mode("overwrite").saveAsTable(table1))
}
assert(e.getMessage.contains(s"does not have [create] privilege on [$defaultDb/$table1]"))
Copy link
Contributor

@bowenliang123 bowenliang123 Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you may use the interceptContains method to simplify the assertions. Very handy and clear.

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you may use the interceptContains method to simplify the assertions. Very handy and clear.

Done. I will refine these test's UT by interceptContains later

}
}
}
}