[KYUUBI #5382][JDBC] Duplication cleanup improvement in JdbcDialect and schema helpers #5490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ls/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/schema/RowSetHelper.scala
Outdated
Show resolved
Hide resolved
...ls/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/dialect/JdbcDialect.scala
Outdated
Show resolved
Hide resolved
...yuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperation.scala
Outdated
Show resolved
Hide resolved
...yuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperation.scala
Outdated
Show resolved
Hide resolved
...ls/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/schema/RowSetHelper.scala
Outdated
Show resolved
Hide resolved
bowenliang123
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5490 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33466 33481 +15
Branches 4401 4405 +4
======================================
- Misses 33466 33481 +15 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
@bowenliang123 hi, thanks for your suggestions, I have made all the changes. Please review it again when you have time :). |
bowenliang123
approved these changes
Oct 21, 2023
Contributor
bowenliang123
left a comment
bowenliang123
left a comment
There was a problem hiding this comment.
LGTM. Wait for @zhaomin1423 's review.
zhaomin1423
reviewed
Oct 22, 2023
...ls/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/schema/RowSetHelper.scala
Outdated
Show resolved
Hide resolved
cxzl25
changed the title
Contributor
|
Thanks for the contribution from @zhuyaogai and the review by @zhaomin1423 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To close #5382.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No