[KYUUBI #5447][AUTHZ] Support Hudi DeleteHoodieTableCommand/UpdateHoodieTableCommand/MergeIntoHoodieTableCommand #5482
Conversation
…ateHoodieTableCommand/MergeIntoHoodieTableCommand
Codecov Report
@@ Coverage Diff @@
## master #5482 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33466 33481 +15
Branches 4401 4405 +4
======================================
- Misses 33466 33481 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...c/main/resources/META-INF/services/org.apache.kyuubi.plugin.spark.authz.serde.QueryExtractor
Outdated
Show resolved
Hide resolved
...c/main/resources/META-INF/services/org.apache.kyuubi.plugin.spark.authz.serde.TableExtractor
Outdated
Show resolved
Hide resolved
...-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala
Outdated
Show resolved
Hide resolved
...scala/org/apache/kyuubi/plugin/spark/authz/ranger/HudiCatalogRangerSparkExtensionSuite.scala
Show resolved
Hide resolved
|
And again, please do not forget the positive cases. |
|
The current implementation looks to break the original intention of plan serde layer. |
How about current? match all case. |
bowenliang123
left a comment
bowenliang123
left a comment
There was a problem hiding this comment.
LGTM. Minor comment.
| @HudiTest | ||
| class HudiCatalogRangerSparkExtensionSuite extends RangerSparkExtensionSuite { | ||
| override protected val catalogImpl: String = "hive" | ||
| override protected val catalogImpl: String = "in-memory" |
There was a problem hiding this comment.
Why we have to change this?
There was a problem hiding this comment.
Why we have to change this?
To trigger a positive case, if not change this, will trigger some hive hms-related derby error and can' run. I have checked that this changing to in-memory the plan is also Hudi's command.
bowenliang123
changed the title
|
Thanks, merged to master. |
4 participants
Why are the changes needed?
To close #5447. Kyuubi authz Support hudi DeleteHoodieTableCommand/UpdateHoodieTableCommand/MergeIntoHoodieTableCommand
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No