Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Oct 18, 2022

Why are the changes needed?

Refer Spark PR: apache/spark#18110
ConfigBuilder builds ConfigEntry which can only read value with one key, if we wanna change the config name but still keep the old one, it's hard to do.

This PR introduce ConfigBuilder.withAlternative, to support reading config value with alternative keys.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@turboFei turboFei requested review from pan3793 and yaooqinn and removed request for yaooqinn October 18, 2022 03:03
@turboFei turboFei self-assigned this Oct 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3659 (e268fef) into master (d410443) will increase coverage by 0.19%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##             master    #3659      +/-   ##
============================================
+ Coverage     51.73%   51.93%   +0.19%     
  Complexity       13       13              
============================================
  Files           482      484       +2     
  Lines         26980    27136     +156     
  Branches       3763     3784      +21     
============================================
+ Hits          13958    14092     +134     
- Misses        11663    11675      +12     
- Partials       1359     1369      +10     
Impacted Files Coverage Δ
...scala/org/apache/kyuubi/config/ConfigBuilder.scala 95.28% <71.42%> (-1.72%) ⬇️
...n/scala/org/apache/kyuubi/config/ConfigEntry.scala 100.00% <100.00%> (ø)
...kyuubi/engine/spark/session/SparkSessionImpl.scala 61.53% <0.00%> (-9.05%) ⬇️
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (-3.23%) ⬇️
...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala 71.42% <0.00%> (-2.35%) ⬇️
...src/main/scala/org/apache/spark/ui/EngineTab.scala 68.75% <0.00%> (-1.99%) ⬇️
...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala 75.90% <0.00%> (-1.88%) ⬇️
...rg/apache/kyuubi/server/api/v1/AdminResource.scala 89.74% <0.00%> (-1.17%) ⬇️
...in/scala/org/apache/kyuubi/sql/KyuubiSQLConf.scala 99.01% <0.00%> (-0.99%) ⬇️
.../org/apache/kyuubi/session/KyuubiSessionImpl.scala 75.78% <0.00%> (-0.81%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@turboFei turboFei closed this in a6832b7 Oct 18, 2022
@turboFei
Copy link
Member Author

thanks, merged to master

@turboFei turboFei deleted the conf_alternative branch October 18, 2022 04:23
@turboFei turboFei added this to the v1.7.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants