Skip to content

Conversation

@cfmcgrady
Copy link
Contributor

@cfmcgrady cfmcgrady commented May 19, 2022

Why are the changes needed?

to close #2706

Spark extensions support Spark-3.3, part of #2620

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@cfmcgrady cfmcgrady changed the title [KYUUBI #22706] Spark extensions support Spark-3.3 [KYUUBI #2706] Spark extensions support Spark-3.3 May 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2707 (0b07b6e) into master (85d68b2) will decrease coverage by 3.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2707      +/-   ##
============================================
- Coverage     64.19%   61.10%   -3.09%     
+ Complexity      282      241      -41     
============================================
  Files           407      404       -3     
  Lines         19113    19044      -69     
  Branches       2572     2563       -9     
============================================
- Hits          12269    11637     -632     
- Misses         5693     6311     +618     
+ Partials       1151     1096      -55     
Impacted Files Coverage Δ
...che/kyuubi/sql/watchdog/MaxPartitionStrategy.scala 0.00% <0.00%> (ø)
...pache/kyuubi/sql/KyuubiSQLExtensionException.scala 0.00% <0.00%> (-100.00%) ⬇️
...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala 0.00% <0.00%> (-94.74%) ⬇️
...ubi/sql/zorder/InsertZorderBeforeWritingBase.scala 0.00% <0.00%> (-89.16%) ⬇️
...cala/org/apache/kyuubi/sql/zorder/ZorderBase.scala 0.00% <0.00%> (-87.50%) ⬇️
.../kyuubi/sql/zorder/OptimizeZorderCommandBase.scala 0.00% <0.00%> (-81.82%) ⬇️
...yuubi/sql/zorder/OptimizeZorderStatementBase.scala 0.00% <0.00%> (-71.43%) ⬇️
...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala 0.00% <0.00%> (-69.57%) ⬇️
...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala 0.00% <0.00%> (-32.36%) ⬇️
...g/apache/kyuubi/sql/KyuubiEnsureRequirements.scala 0.00% <0.00%> (-30.19%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d68b2...0b07b6e. Read the comment docs.

@cfmcgrady cfmcgrady requested review from turboFei and ulysses-you May 19, 2022 11:42
@cfmcgrady cfmcgrady requested a review from yaooqinn May 23, 2022 03:04
@pan3793 pan3793 added this to the v1.6.0 milestone May 23, 2022
@pan3793
Copy link
Member

pan3793 commented May 23, 2022

Thanks, merging to master

@pan3793 pan3793 closed this in 85cbea4 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask] Kyuubi Spark Extension support Spark 3.3

5 participants