-
Notifications
You must be signed in to change notification settings - Fork 972
[KYUUBI #1948][FOLLOWUP] Relocate fb303 classes #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… due to exception
Codecov Report
@@ Coverage Diff @@
## master #2096 +/- ##
============================================
- Coverage 60.47% 60.45% -0.02%
+ Complexity 109 108 -1
============================================
Files 314 314
Lines 15200 15200
Branches 1950 1950
============================================
- Hits 9192 9189 -3
- Misses 5234 5237 +3
Partials 774 774
Continue to review full report at Codecov.
|
|
@lawulu, would you please confirm #2093 gets fixed by this PR? This issue should only happen when users use HiveExternalCatalog to connect remote HMS, it is not covered by the current UT. And because of #1953 (comment), it's not easy to add a simple UT. I would like to open a new issue to track the follow-up IT, and merge this one after @lawulu confirmed, WDYT? @yaooqinn |
|
Yes, it works after the fix |
|
@pan3793 @yaooqinn, @lawulu confirmed that the bug mentioned is fixed, therefore could you please merge to master firstly because the issue is the blocker of 1.5.0 release? The UT/IT tests could be followed up after this pull request is merged by using docker to create the remote HMS. |
|
Thanks, merging to master/1.5 |
### _Why are the changes needed?_ We should relocate fb303 classes to avoid conflict, fix #2093. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2096 from SteNicholas/KYUUBI-2093. Closes #1948 2095f83 [SteNicholas] [KYUUBI #2093] kyuubi beeline can not connect the kyuubi server due to exception Authored-by: SteNicholas <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 12d5642) Signed-off-by: Cheng Pan <[email protected]>
### _Why are the changes needed?_ We should relocate fb303 classes to avoid conflict, fix apache#2093. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#2096 from SteNicholas/KYUUBI-2093. Closes apache#1948 2095f83 [SteNicholas] [KYUUBI apache#2093] kyuubi beeline can not connect the kyuubi server due to exception Authored-by: SteNicholas <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Why are the changes needed?
We should relocate fb303 classes to avoid conflict, fix #2093.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request