Skip to content

Conversation

@SteNicholas
Copy link
Member

@SteNicholas SteNicholas commented Mar 10, 2022

Why are the changes needed?

We should relocate fb303 classes to avoid conflict, fix #2093.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

Codecov Report

Merging #2096 (2095f83) into master (a71c511) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2096      +/-   ##
============================================
- Coverage     60.47%   60.45%   -0.02%     
+ Complexity      109      108       -1     
============================================
  Files           314      314              
  Lines         15200    15200              
  Branches       1950     1950              
============================================
- Hits           9192     9189       -3     
- Misses         5234     5237       +3     
  Partials        774      774              
Impacted Files Coverage Δ
.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala 75.00% <0.00%> (-2.78%) ⬇️
.../org/apache/kyuubi/operation/KyuubiOperation.scala 61.33% <0.00%> (-1.34%) ⬇️
...ala/org/apache/kyuubi/session/SessionManager.scala 85.12% <0.00%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71c511...2095f83. Read the comment docs.

@pan3793 pan3793 changed the title [KYUUBI #2093] Kyuubi beeline can not connect the kyuubi server due to exception [KYUUBI #1948][FOLLOWUP] Relocate fb303 classes Mar 10, 2022
@pan3793 pan3793 added the kind:bug This is a clearly a bug label Mar 10, 2022
@pan3793 pan3793 added this to the v1.5.0 milestone Mar 10, 2022
@pan3793
Copy link
Member

pan3793 commented Mar 10, 2022

@lawulu, would you please confirm #2093 gets fixed by this PR? This issue should only happen when users use HiveExternalCatalog to connect remote HMS, it is not covered by the current UT. And because of #1953 (comment), it's not easy to add a simple UT. I would like to open a new issue to track the follow-up IT, and merge this one after @lawulu confirmed, WDYT? @yaooqinn

@lawulu
Copy link

lawulu commented Mar 10, 2022

Yes, it works after the fix

@SteNicholas
Copy link
Member Author

SteNicholas commented Mar 10, 2022

@pan3793 @yaooqinn, @lawulu confirmed that the bug mentioned is fixed, therefore could you please merge to master firstly because the issue is the blocker of 1.5.0 release? The UT/IT tests could be followed up after this pull request is merged by using docker to create the remote HMS.
@lawulu, thanks for helping to confirm whether the bug you report is fixed.(^∀^)

@pan3793
Copy link
Member

pan3793 commented Mar 11, 2022

Thanks, merging to master/1.5

@pan3793 pan3793 closed this in 12d5642 Mar 11, 2022
pan3793 pushed a commit that referenced this pull request Mar 11, 2022
### _Why are the changes needed?_

We should relocate fb303 classes to avoid conflict, fix #2093.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2096 from SteNicholas/KYUUBI-2093.

Closes #1948

2095f83 [SteNicholas] [KYUUBI #2093] kyuubi beeline can not connect the kyuubi server due to exception

Authored-by: SteNicholas <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 12d5642)
Signed-off-by: Cheng Pan <[email protected]>
wForget pushed a commit to wForget/kyuubi that referenced this pull request Mar 11, 2022
### _Why are the changes needed?_

We should relocate fb303 classes to avoid conflict, fix apache#2093.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes apache#2096 from SteNicholas/KYUUBI-2093.

Closes apache#1948

2095f83 [SteNicholas] [KYUUBI apache#2093] kyuubi beeline can not connect the kyuubi server due to exception

Authored-by: SteNicholas <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug This is a clearly a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] kyuubi beeline can not connect the kyuubi server due to exception

5 participants