-
Notifications
You must be signed in to change notification settings - Fork 980
[KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from spark-hive and fix detect deps change workflow #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
let me try to revert the change for kyuubi-hive-beeline module |
|
you can rebase on #1854 if it is merged. |
|
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
=========================================
Coverage 59.70% 59.70%
Complexity 268 268
=========================================
Files 282 282
Lines 13978 13978
Branches 1781 1781
=========================================
Hits 8346 8346
Misses 4924 4924
Partials 708 708 Continue to review full report at Codecov.
|
|
@turboFei The detect dependencyList changes workflow failed because of cache issue, I updated and solved it, please take a look again. |
turboFei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
thanks, merged to master |
Why are the changes needed?
The previous PR did not handle log4j 1.2 deps of
spark-hive, and the current detect deps change workflow has the dirty cache issue, this PR also fix it.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request