Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Jan 27, 2022

Why are the changes needed?

Bump Iceberg 0.13.0 and enable Iceberg test with Spark 3.2.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@pan3793 pan3793 marked this pull request as draft January 27, 2022 11:25
s"spark.sql.catalog.$catalog.type" -> "hadoop",
s"spark.sql.catalog.$catalog.warehouse" -> warehouse.toString,
// TODO maybe an issue of iceberg 0.13.0
s"spark.sql.catalog.$catalog.default-namespace" -> "default",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this because of apache/iceberg#4024

@pan3793 pan3793 marked this pull request as ready for review February 1, 2022 19:54
@pan3793 pan3793 self-assigned this Feb 1, 2022
@pan3793 pan3793 added this to the v1.5.0 milestone Feb 1, 2022
@pan3793 pan3793 requested a review from yaooqinn February 1, 2022 19:54
@codecov-commenter
Copy link

Codecov Report

Merging #1849 (39b156b) into master (b2bad04) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1849   +/-   ##
=========================================
  Coverage     59.70%   59.70%           
- Complexity      267      269    +2     
=========================================
  Files           282      282           
  Lines         13978    13978           
  Branches       1781     1781           
=========================================
+ Hits           8345     8346    +1     
  Misses         4924     4924           
+ Partials        709      708    -1     
Impacted Files Coverage Δ
...rg/apache/kyuubi/engine/trino/TrinoStatement.scala 65.88% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bad04...39b156b. Read the comment docs.

@pan3793
Copy link
Member Author

pan3793 commented Feb 4, 2022

Merging to master

@pan3793 pan3793 closed this in 216dd66 Feb 4, 2022
@pan3793 pan3793 deleted the iceberg-0.13.0 branch February 4, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants