[KYUUBI #1769][FOLLOWUP] Some cleanups for log4j properties #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
and the licenses? |
Member
Author
Sorry, which file should I modify? |
Member
|
LICENSE-binary |
yaooqinn
approved these changes
Jan 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #1842 +/- ##
============================================
+ Coverage 59.46% 59.71% +0.24%
+ Complexity 272 271 -1
============================================
Files 277 282 +5
Lines 13853 13989 +136
Branches 1776 1785 +9
============================================
+ Hits 8238 8353 +115
- Misses 4911 4925 +14
- Partials 704 711 +7
Continue to review full report at Codecov.
|
pan3793
approved these changes
Jan 26, 2022
turboFei
force-pushed
the
remove_log4j1
branch
from
975e42f to
e55fd2e
Compare
yaooqinn
reviewed
Jan 26, 2022
yaooqinn
reviewed
Jan 26, 2022
turboFei
force-pushed
the
remove_log4j1
branch
2 times, most recently
from
d83f9bc to
499f935
Compare
turboFei
force-pushed
the
remove_log4j1
branch
from
499f935 to
034b04d
Compare
Member
Author
|
thanks, merged to master |
Closed
3 tasks
pan3793
pushed a commit
that referenced
this pull request
Feb 1, 2022
…-jdbc(shaded) modules ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Revert the dependency changes for kyuubi-hive-jdbc and kyuubi-hive-jdbc-shaded modules from #1842 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1854 from turboFei/slf4j-api. Closes #1769 dffe6c5 [Fei Wang] reserve for kyuubi-hive-beeline 2001243 [Fei Wang] [KYUUBI #1769][FOLLOWUP] Revert the dependency change for kyuubi-hive-beeline and kyuubi-hive-jdbc(shaded) modules Authored-by: Fei Wang <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This is a followup of #1769. Cleanup the log4j properties files and using log4j2.properties for UT.
How was this patch tested?
Passed UT.