[KYUUBI #939][FOLLOWUP] Refine pom.xml #1041
Conversation
|
|
||
| <dependency> | ||
| <groupId>org.antlr</groupId> | ||
| <artifactId>antlr4-runtime</artifactId> |
There was a problem hiding this comment.
It's already pulled by spark-sql
There was a problem hiding this comment.
we can also remove the antlr4-runtime and parent pom.
There was a problem hiding this comment.
Just make sure we don't miss anything here, Spark-3.1.2 depends antlr4-runtime:4.8-1, but kyuubi generates source code with antlr-maven-plugin:4.7. Is there any compatibility issue?
<antlr4.version>4.8-1</antlr4.version>There was a problem hiding this comment.
Yeah, we should bump 4.8-1 to align with spark, 4.7 should work but will print warning messages if the antlr version is not exactly matched.
There was a problem hiding this comment.
Actually, we should bump antlr 4.8, see apache/spark#32603
| <dependency> | ||
| <groupId>org.antlr</groupId> | ||
| <artifactId>antlr4-runtime</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
it's likely an accident change in #990, reverted.
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
============================================
+ Coverage 78.40% 78.42% +0.01%
Complexity 61 61
============================================
Files 167 167
Lines 6196 6196
Branches 723 723
============================================
+ Hits 4858 4859 +1
+ Misses 915 914 -1
Partials 423 423
Continue to review full report at Codecov.
|
|
thanks, merging to master |
4 participants
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request