-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamically adjust the upper limit of the data that each layer configure option. #497
Merged
Merged
Changes from 9 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b3e1fb3
Update Rocksdb options, enable level_compaction_dynamic_level_bytes f…
WyattJia bd2e708
Merge pull request #1 from WyattJia/max_bytes_for_level_base
WyattJia eacb3ea
Format config.cc.
WyattJia bf8c93f
Lint config.cc, remove useless comma.
WyattJia 8aa0025
Update conf, rewrite levels target size option comments.
WyattJia d156b9c
Update level_compaction_dynamic_level_bytes config load.
WyattJia d5aa2f5
Update kvrocks.conf
WyattJia d432188
Update kvrocks.conf
WyattJia 335c033
Update kvrocks.conf
WyattJia 612e690
Update levels target size option comments.
WyattJia de62f14
Update levels target size option comments.
WyattJia dceca92
Update level_compaction_dynamic_level_bytes config load.
WyattJia d78c3df
Fix level_compaction_dynamic_level_bytes conf value error.
WyattJia 14a728c
Lint config.cc
WyattJia d4553b4
Update src/config.cc
git-hulk f1c8a95
Enable lz4 and zstd compression algorithms.
WyattJia c30aa27
Fix configura option unit error.
WyattJia c3f970e
Update src/config.cc
git-hulk 77070db
Revert 267b45ee886, add compression algorithum.
WyattJia 27df4cb
Fix configura option unit error.
WyattJia 30646b7
Revert blob_file_size default unit error.
WyattJia 31e8773
Update tests/config_test.cc
git-hulk 278a3c1
Update src/config.cc
git-hulk c73f2cf
Update src/config.cc
git-hulk 31eb562
Update .gitignore
WyattJia d2f7ad2
Update config.cc
WyattJia 4fc9bbf
Update kvrocks.conf
WyattJia a35ad25
Update kvrocks.conf
WyattJia b695d71
Update max_bytes_for_level_base unit bytes to MiB.
WyattJia 004c97e
Fix config.cc, max_bytes_for_level_base unit bytes to MiB.
WyattJia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this config has
bytes
word, we should use byte unit, right? or we rename it to level_base_size? maybe rocksdb name is better?This commit is not released in newest version, we have chances to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I also think
bytes
is better.