-
Notifications
You must be signed in to change notification settings - Fork 562
feat(command): add a new command to enable/disable/dump the memory profiling #3007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
git-hulk
merged 9 commits into
apache:unstable
from
git-hulk:feature/memory-profiling-command
Jun 4, 2025
Merged
feat(command): add a new command to enable/disable/dump the memory profiling #3007
git-hulk
merged 9 commits into
apache:unstable
from
git-hulk:feature/memory-profiling-command
Jun 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3451ceb
to
eac143b
Compare
…he memory profiling
eac143b
to
6ad423b
Compare
PragmaTwice
reviewed
Jun 2, 2025
PragmaTwice
reviewed
Jun 2, 2025
PragmaTwice
reviewed
Jun 2, 2025
eb15f28
to
062cf9e
Compare
PragmaTwice
reviewed
Jun 3, 2025
13d04a5
to
8b17084
Compare
PragmaTwice
reviewed
Jun 3, 2025
Co-authored-by: Twice <[email protected]>
PragmaTwice
reviewed
Jun 4, 2025
PragmaTwice
reviewed
Jun 4, 2025
PragmaTwice
approved these changes
Jun 4, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3006.
Currently, it's hard to identify where's occupying the memory when it goes high.
To mitigate this issue, we would like to introduce a profiling command to make the
process easier.
To enable this feature, you need to set the
MALLOC_CONF
environment variable before running the Kvrocks server, like the following instruction:or
MALLOC_CONF="prof:true,background_thread:true" ./kvrocks -c kvrocks.conf
You could also enable the profiling feature without activating the profiling behavior to avoid the overhead:
You can then enable it at runtime if necessary: