Skip to content

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented May 7, 2025

This closes #2939.

@git-hulk git-hulk requested a review from PragmaTwice May 7, 2025 13:16
@PragmaTwice
Copy link
Member

PragmaTwice commented May 7, 2025

Also we can revert changes to x.py.

@PragmaTwice PragmaTwice changed the title chore(tests): remove SST load command test and gorocksdb chore(tests): remove SST load command test and grocksdb May 7, 2025
@git-hulk
Copy link
Member Author

git-hulk commented May 7, 2025

Also we can revert changes to x.py.

Oh, yes. I forgot this part.

Copy link

sonarqubecloud bot commented May 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
38.0% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@git-hulk git-hulk merged commit 2b290b3 into apache:unstable May 7, 2025
34 of 35 checks passed
@ltagliamonte-dd
Copy link
Contributor

Thanks folks, FYI there was no need to remove this dep, it was enough to update the lib to latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gorocksdb in the test case to avoid blocking the rocksdb version upgrade
4 participants