Skip to content

Conversation

SharonIV0x86
Copy link
Contributor

ssize_t n = entries_.size();

This intermediate variable for getting the size is not necessary and the vector size can be directly returned by casting it to ssize_t

@SharonIV0x86 SharonIV0x86 changed the title Removed need for the intermediate variable in Size function (fix) Removed need for the intermediate variable in Size function Feb 27, 2025
@torwig
Copy link
Contributor

torwig commented Feb 27, 2025

@SharonIV0x86 You can run ./x.py format before committing and pushing your code to have it be formatted and make the CI happy.

@SharonIV0x86
Copy link
Contributor Author

@SharonIV0x86 You can run ./x.py format before committing and pushing your code to have it be formatted and make the CI happy.

Thanks for the suggestion, i executed the ./x.py format and it modified 18 more files i guess that code was from the recent merges to the repo, as the code was updated just a few hours ago, ig this is normal? Should proceed with the push?

@torwig torwig changed the title (fix) Removed need for the intermediate variable in Size function fix: Remove need for the intermediate variable in Size function Feb 27, 2025
@torwig
Copy link
Contributor

torwig commented Feb 27, 2025

@SharonIV0x86 I renamed the PR, since CI didn't accept the prefix.

@torwig
Copy link
Contributor

torwig commented Feb 27, 2025

@SharonIV0x86 Thank you for your contribution.

@PragmaTwice PragmaTwice changed the title fix: Remove need for the intermediate variable in Size function chore: Remove need for the intermediate variable in Size function Feb 28, 2025
@PragmaTwice
Copy link
Member

PragmaTwice commented Feb 28, 2025

I'm fine with it. But to make it clear, it's NOT a fix. No functional changes in this patch, just code style changes.

@PragmaTwice PragmaTwice changed the title chore: Remove need for the intermediate variable in Size function chore: remove need for the intermediate variable in Size function Feb 28, 2025
Copy link

@git-hulk git-hulk merged commit 34007db into apache:unstable Feb 28, 2025
37 checks passed
@SharonIV0x86 SharonIV0x86 deleted the fix/LogCollector branch May 1, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants