Skip to content

Conversation

wyxxxcat
Copy link
Contributor

Issue

close: #2792

Proposed Changes

  • implement tdigest.add command.
  • add test

Comment

...

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General LGTM

Copy link
Member

@LindaSummer LindaSummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyxxxcat ,

Thanks very much for your contribution! 😊

Generally LGTM, left some comments.

Best Regards,
Edward

@LindaSummer
Copy link
Member

Hi @wyxxxcat ,

You could enable your fork repo's Github Action and it will trigger ci pipeline inside your own repo without the upstream repo's permission.

It may accelerate your development and review process. 😁

Best Regards,
Edward

@wyxxxcat wyxxxcat force-pushed the tdigest_add branch 3 times, most recently from 499467d to c148fae Compare February 26, 2025 09:38
Copy link

@mapleFU
Copy link
Member

mapleFU commented Feb 26, 2025

Will merge if no negative comments tomorrow

@wyxxxcat wyxxxcat requested a review from LindaSummer February 27, 2025 01:49
Copy link
Member

@LindaSummer LindaSummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyxxxcat ,

Thanks very much for your effort! 😊

I left comment for error message compalibility with redis. I think it's not mandatory for tdigest command and current messages are reasonable, but will be better to keep compalibility.

Other parts are LGTM.

Best Regards,
Edward

@PragmaTwice
Copy link
Member

Let's merge it first. Improvement can happen in further PRs.

@PragmaTwice PragmaTwice merged commit 0e9c93c into apache:unstable Feb 27, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TDigest: Implement ADD command for TDigest Algorithm
4 participants