Skip to content

fix(search): misidentify DESC token in SQL parser #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2024
Merged

fix(search): misidentify DESC token in SQL parser #2439

merged 1 commit into from
Jul 21, 2024

Conversation

PragmaTwice
Copy link
Member

  • AS IS:
    select a from b order by c desc limit 10 -> ASC

  • TOBE:
    select a from b order by c desc limit 10 -> DESC

@PragmaTwice PragmaTwice requested a review from git-hulk July 21, 2024 05:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
59.4% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice merged commit ec3d903 into apache:unstable Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PragmaTwice @git-hulk