Refactor Column Family Handling #2296
Conversation
# Conflicts: # src/server/server.cc
| @@ -1334,11 +1334,19 @@ Status SlotMigrator::migrateIncrementalDataByRawKV(uint64_t end_seq, BatchSender | |||
| break; | |||
| } | |||
| case engine::WALItem::Type::kTypePut: { | |||
| if (item.column_family_id > kMaxColumnFamilyID) { | |||
There was a problem hiding this comment.
This avoid get and put default CF
I don't think shared_ptr is useful here. Just put the ownership to the storage class. |
src/storage/storage.cc
Outdated
| std::vector<std::string> cf_names_except_default; | ||
| const auto &all_column_family = ColumnFamilyConfigs::ListAllColumnFamily(); | ||
| for (const auto &cf : all_column_family) { | ||
| if (cf.Name() != rocksdb::kDefaultColumnFamilyName) { | ||
| cf_names_except_default.emplace_back(cf.Name()); | ||
| } | ||
| } |
There was a problem hiding this comment.
all_column_family | transform([](..){ name }) | remove_if([](..){ v != default; })
You can use range-v3 here.
There was a problem hiding this comment.
Anyway the logic is just same here...
There was a problem hiding this comment.
I'm thinking if we can move it into a function, like ColumnFamilyConfigs::ListColumnFamiliesWithoutDefault();
mapleFU
force-pushed
the
refactor-cf-handling
branch
from
ac845e5 to
7451082
Compare
mapleFU
force-pushed
the
refactor-cf-handling
branch
from
7451082 to
8869ace
Compare
mapleFU
force-pushed
the
refactor-cf-handling
branch
from
8869ace to
0f332ae
Compare
mapleFU
force-pushed
the
refactor-cf-handling
branch
from
5e976f6 to
d0c9b19
Compare
mapleFU
force-pushed
the
refactor-cf-handling
branch
from
d0c9b19 to
dbf7d7b
Compare
|
|
@git-hulk @PragmaTwice Would you mind take a look? |
|
@mapleFU Sure, will take a look today. |
TBD: should we add a global CF manager with
std::shared_ptr?