fix(debug command): update err msg int -> integer
#2046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems lint failed, would you mind run |
done, thank you very much |
mapleFU
reviewed
Jan 23, 2024
src/common/status.h
Outdated
| @@ -168,7 +168,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) < sizeof(std::string)>> : | |||
| StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new std::string(*std::move(v))) {} // NOLINT | |||
| template <typename U, typename std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0> | |||
| StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT | |||
| : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {} | |||
| : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {} | |||
There was a problem hiding this comment.
cc @PragmaTwice 🤔 why would this file always get format?
There was a problem hiding this comment.
This was caused by clang-format-16 behaving differently from clang-format-14, that said clang-format-16 will remove the space between the type and &&, but clang-format-14 won't do that.
mapleFU
reviewed
Jan 23, 2024
git-hulk
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2045