Skip to content

Minor: improve the style of zdiff #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

Minor: improve the style of zdiff #2027

merged 1 commit into from
Jan 18, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jan 17, 2024

  1. use std::move if possible
  2. use std::set to replace std::map<..., bool>

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

torwig
torwig approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mapleFU Thank you for your work.

@git-hulk git-hulk merged commit 19258a9 into apache:unstable Jan 18, 2024
@mapleFU mapleFU deleted the minor-optimize-zdiff branch January 18, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapleFU @git-hulk @torwig