Add support of the command ZDIFF and ZDIFFSTORE

[MaheshMadushan]

Add support of the command ZDIFF and ZDIFFSTORE #1984

• ZDIFF
• ZDIFFSTORE

[torwig]

@MaheshMadushan Thank you for the contribution.
You can format the codebase by running ./x.py format.

[MaheshMadushan]

@MaheshMadushan Thank you for the contribution. You can format the codebase by running ./x.py format.

Hi @torwig , formatting issue fixed. Thank you.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[torwig]

@MaheshMadushan LGTM, nicely done!
Could you please add some edge-cases tests,? For example, if the first set is empty, doesn't exist, one of the other sets doesn't exist, etc.

[MaheshMadushan]

Hi @torwig . Thanks for the feedback. will add edge test cases for the feature.

[torwig]

@git-hulk Are we waiting for additional test in this PR or it will be a separate one?

[git-hulk]

@git-hulk Are we waiting for additional test in this PR or it will be a separate one?

@torwig ohh, sorry for missing your previous comment. @MaheshMadushan Could you please add the edge cases as @torwig mentioned in this PR?

Wait for more test cases

[MaheshMadushan]

@git-hulk Are we waiting for additional test in this PR or it will be a separate one?

@torwig ohh, sorry for missing your previous comment. @MaheshMadushan Could you please add the edge cases as @torwig mentioned in this PR?

will add them asap.

[torwig]

@MaheshMadushan @git-hulk I'm also thinking about one optimization: when the source zset is empty - I guess in this case we can make early return and there is no sense to traverse all the others zsets. Is it correct?

[git-hulk]

@MaheshMadushan @git-hulk I'm also thinking about one optimization: when the source zset is empty - I guess in this case we can make early return and there is no sense to traverse all the others zsets. Is it correct?

Good point.

[MaheshMadushan]

@MaheshMadushan @git-hulk I'm also thinking about one optimization: when the source zset is empty - I guess in this case we can make early return and there is no sense to traverse all the others zsets. Is it correct?

Will fix this.

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud

[git-hulk]

@MaheshMadushan Thanks for your contribution.

[MaheshMadushan]

@git-hulk @torwig Thank you for feedback.