Skip to content

Conversation

jyf111
Copy link
Contributor

@jyf111 jyf111 commented Jan 6, 2024

This PR adds support of the BITFIELD_RO command.

closes #1954.

Note: The doc shows that the syntax of bitfield_ro only allows the get subcommand, but the overflow subcommand can also appear without error, although it has no effect (tested on redis-server).

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General looks ok to me

Copy link

sonarqubecloud bot commented Jan 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@git-hulk git-hulk merged commit 74a1f42 into apache:unstable Jan 6, 2024
git-hulk pushed a commit to git-hulk/kvrocks that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of the command BITFIELD_RO
4 participants