Fix TBB compile failure due to -Werror and #warning
#1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a glibc header, a warning diagnostic message will be emitted while optimization level is low. And if `TBB_STRICT` is enabled, all warnings will be treated as error and then make the compilation of TBB fail. We disable the option and thus solve #1885.
git-hulk
approved these changes
Nov 9, 2023
torwig
approved these changes
Nov 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a glibc header
features.h, a warning diagnostic message will be emitted while_FORTIFY_SOURCEis used and the current optimization level is low.And if
TBB_STRICTis enabled, all warnings will be treated as errors (-Werror) and then make the compilation of TBB fail.We disable the option and thus solve #1885.