Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for the JSON.ARRTRIM command #1881

Merged
merged 16 commits into from
Nov 12, 2023
Merged

Support for the JSON.ARRTRIM command #1881

merged 16 commits into from
Nov 12, 2023

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Nov 6, 2023

close #1811

Redis doc JSON.ARRTRIM

@jihuayu
Copy link
Member Author

jihuayu commented Nov 7, 2023

@git-hulk How can I deal with this Duplication。
I don't think this is duplication.

@git-hulk
Copy link
Member

git-hulk commented Nov 7, 2023

@jihuayu Can ignore this wrong duplication report.

@jihuayu jihuayu marked this pull request as ready for review November 7, 2023 12:40
@jihuayu
Copy link
Member Author

jihuayu commented Nov 8, 2023

Darwin complier alway calls me no matching function for call to 'max' in auto begin_index = start < 0 ? std::max(len + start, 0l) : start; I have already #include <algorithm>, but it still cannot be found.

I don't have any Mac device. Can someone tell me what I should do?

@git-hulk
Copy link
Member

git-hulk commented Nov 8, 2023

@jihuayu Let me have a check later.

git-hulk
git-hulk reviewed Nov 8, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
jihuayu

This comment was marked as off-topic.

Sign in to view

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
11.0% 11.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@git-hulk git-hulk merged commit 21c8168 into apache:unstable Nov 12, 2023
29 of 30 checks passed
@jihuayu jihuayu mentioned this pull request Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the JSON.ARRTRIM command
3 participants
@jihuayu @git-hulk @PragmaTwice