Skip to content

Add support of command FCALL_RO #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2023
Merged

Add support of command FCALL_RO #1791

merged 3 commits into from
Oct 1, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Oct 1, 2023 •
edited
Loading

We add the support of command FCALL_RO based on the Redis Function implementation #1788.

TODO:

  • go tests

@PragmaTwice PragmaTwice requested review from git-hulk and torwig October 1, 2023 06:37
@PragmaTwice PragmaTwice marked this pull request as ready for review October 1, 2023 06:37
git-hulk
git-hulk reviewed Oct 1, 2023
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PragmaTwice This PR Looks good

@PragmaTwice PragmaTwice merged commit f3d7ef4 into apache:unstable Oct 1, 2023
@PragmaTwice PragmaTwice mentioned this pull request Oct 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig