Split Inter in ZSet::InterStore into a separate function #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI TSAN show ZINTERSTORE may has a deadlock after introducing locks to DEL in apache#1712. In ZSet::InterStore if the dst key was inside the source key list we may have a deadlock since the OverWrite function will also lock the dst key. In this PR, we split Inter in ZSet::InterStore into a separate function, just like the Set apis. After this PR, after the CI verification in apache#1712, it can pass the CI verification now.
git-hulk
previously approved these changes
Sep 2, 2023
PragmaTwice
reviewed
Sep 2, 2023
PragmaTwice
approved these changes
Sep 3, 2023
torwig
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI TSAN show ZINTERSTORE may has a deadlock after introducing
locks to DEL in #1712. In ZSet::InterStore if the dst key was
inside the source key list we may have a deadlock since the
OverWrite function will also lock the dst key.
In this PR, we split Inter in ZSet::InterStore into a separate
function, just like the Set apis.
After this PR, after the CI verification in #1712, it can pass
the CI verification now. Closes #1715
This PR also do a saved_cnt cleanup since it is same as members.size().