build: tidy dockerfile #1477
Merged
build: tidy dockerfile #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
tisonkun
commented
May 27, 2023
| compactdb | ||
| testdb | ||
|
|
||
| build |
There was a problem hiding this comment.
Add .gitignore content. Avoid build content conflict issues.
tisonkun
commented
May 27, 2023
| @@ -19,10 +19,6 @@ FROM alpine:3.16 as build | |||
|
|
|||
| ARG MORE_BUILD_ARGS | |||
|
|
|||
| # workaround tzdata install hanging | |||
| ENV TZ=Etc/UTC | |||
There was a problem hiding this comment.
After switching to Alpine, we don't need this trick.
tisonkun
commented
May 27, 2023
| VOLUME /var/lib/kvrocks | ||
|
|
||
| RUN chown kvrocks:kvrocks /var/lib/kvrocks | ||
| COPY --from=build /kvrocks/build/kvrocks /bin/ |
There was a problem hiding this comment.
Simplify a bit layout:
/bin/kvrocks
/bin/redis-cli
/kvrocks/<LICENSE/NOTICE>
/var/...
tisonkun
commented
May 27, 2023
| VOLUME /var/lib/kvrocks | ||
|
|
||
| RUN chown kvrocks:kvrocks /var/lib/kvrocks |
|
cc @aleksraiden may you verify this patch also. |
Awesome! LGTM |
torwig
approved these changes
May 27, 2023
|
Merging... Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments inline.