Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrongly append the ERR prefix in no script error #1162

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix wrongly append the ERR prefix in no script error #1162

merged 1 commit into from
Dec 6, 2022

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Dec 5, 2022

This closes #1161

@git-hulk git-hulk changed the title Fix don't append the ERR prefix in no script error Fix wrongly append the ERR prefix in no script error Dec 5, 2022
tisonkun
tisonkun approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although return Status::Ok with a Redis::Error payload seems weird, this patch fixes the issue.

+1 for merge.

tisonkun
tisonkun approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although return Status::Ok with a Redis::Error payload seems weird, this patch fixes the issue.

+1 for merge.

@git-hulk
Copy link
Member Author

git-hulk commented Dec 5, 2022

Although return Status::Ok with a Redis::Error payload seems weird, this patch fixes the issue.

+1 for merge.

Yes, we are mixed using the status message and error output in many places. But we can unify them in the next PR if it's confusing.

@git-hulk
Copy link
Member Author

git-hulk commented Dec 6, 2022

Thanks all, merging...

@git-hulk git-hulk merged commit 9e4bb2c into apache:unstable Dec 6, 2022
@lloydzhou lloydzhou mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@torwig torwig Awaiting requested review from torwig

@ShooterIT ShooterIT Awaiting requested review from ShooterIT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent NOSCRIPT error reply in the eval command
3 participants
@git-hulk @tisonkun @PragmaTwice