MINOR: Fix meaningless message in assertNull validation#9965
Merged
Conversation
Member
Author
|
@guozhangwang , hello, PTAL. |
Member
|
It seems to me the title is a bit confusing. The first argument is "error message" rather than "expected object". |
dengziming
changed the title
Member
Author
|
@chia7712 Thank you, I mistakenly treat the second parameter as "error message", I have changed the title. |
chia7712
approved these changes
Jan 27, 2021
chia7712
left a comment
chia7712
left a comment
Member
There was a problem hiding this comment.
@dengziming Thanks for your patch. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
I think the author wants to say assertEquals(null, xxx)
Summary of testing strategy (including rationale)
QA
Committer Checklist (excluded from commit message)